xfce4-dict merge requestshttps://gitlab.xfce.org/apps/xfce4-dict/-/merge_requests2023-11-16T23:18:41Zhttps://gitlab.xfce.org/apps/xfce4-dict/-/merge_requests/12Support IPv6 DICT servers, treat port as string not integer2023-11-16T23:18:41ZKlemens NanniSupport IPv6 DICT servers, treat port as string not integerI run my own server, specified [`localhost`](http://localhost) which resolves to `::1` and it failed to connect.
There is no helpful error message, so after a little tracing it showed xfce4-dict is still IPv4-only.
Fix that.I run my own server, specified [`localhost`](http://localhost) which resolves to `::1` and it failed to connect.
There is no helpful error message, so after a little tracing it showed xfce4-dict is still IPv4-only.
Fix that.https://gitlab.xfce.org/apps/xfce4-dict/-/merge_requests/11Add icons at missing sizes, clean up SVG metadata2023-06-06T20:36:35ZnewhoaAdd icons at missing sizes, clean up SVG metadata@Tamaranch Should all icons/rDNS names be lowercase? I've noticed there are only a few that aren't (like Dictionary here) and I've seen a few MRs merged in other projects where they have been lowered. If so I can submit additional MRs to...@Tamaranch Should all icons/rDNS names be lowercase? I've noticed there are only a few that aren't (like Dictionary here) and I've seen a few MRs merged in other projects where they have been lowered. If so I can submit additional MRs to address that while I'm at these. Also, sorry if all these icon MRs are annoying, but I figured I'd just go ahead and start going down the line and try to get them all done. I know it's pretty superficial/trivial I guess but hopefully it'll help in some cases (esp HiDPI).
Thanks!
---
Adds app icon at 64px, 96px. This should give a
cleaner look in system menus like App Finder, Whisker Menu.
Removes export path strings from SVGs, metadata which Inkscape added on export.
Note:
Inkscape recently changed to save export paths as relative
paths so this shouldn't be an issue in the future.0.8.6https://gitlab.xfce.org/apps/xfce4-dict/-/merge_requests/10Use "logo-icon-name" instead of "logo" in about dialog2023-04-21T20:37:50ZGaël BonithonUse "logo-icon-name" instead of "logo" in about dialogImproves consistency with other components and ensures that the icon is
properly scaled and sharp when UI scale > 1.Improves consistency with other components and ensures that the icon is
properly scaled and sharp when UI scale > 1.0.8.5https://gitlab.xfce.org/apps/xfce4-dict/-/merge_requests/9autoconf: Use AC_CONFIG_MACRO_DIRS2023-04-21T20:37:39ZAkbarkhon Variskhanovautoconf: Use AC_CONFIG_MACRO_DIRS0.8.5https://gitlab.xfce.org/apps/xfce4-dict/-/merge_requests/8Update COPYING (Issue #7)2023-04-21T20:36:29ZKevin BowenUpdate COPYING (Issue #7)
closes #7
closes #70.8.5https://gitlab.xfce.org/apps/xfce4-dict/-/merge_requests/7Escape markup in server information2023-04-21T20:36:07ZHunter Turcinhuntertur@gmail.comEscape markup in server informationDuring the discussion on my previously-reported issue at https://gitlab.xfce.org/apps/xfce4-dict/-/issues/6 I spent some time looking through the source code of xfce4-dict to understand that issue better. While looking through the source...During the discussion on my previously-reported issue at https://gitlab.xfce.org/apps/xfce4-dict/-/issues/6 I spent some time looking through the source code of xfce4-dict to understand that issue better. While looking through the source code, I noticed an unrelated issue that could allow server information responses that contain Pango markup tags to result in unexpectedly-formatted output and warnings printed to the console.
# Reproduction Steps
1. Install `dictd`
2. Create `/etc/dictd/test.txt`
3. Insert the text `This is a test.</tt> <b>Look at me!`
4. Edit `/etc/dictd/dictd.conf`
5. Insert in section `global` `site /etc/dictd/test.txt`
6. Build xfce4-dict from source
7. Open Dictionary Server in Preferences
8. Set server to localhost
9. Click the lightbulb
10. Verify the output is no longer monospace
11. Verify a GTK warning is printed to the console about the markup
# Post-Patch Steps
In Step 10, the output should be entirely monospace, and in Step 11, no warnings about markup should be printed to the console.
# Screenshots
Before:
![image](/uploads/c347385777224f13ad7e27b6521135a8/image.png)
After:
![image](/uploads/81caf6a5ca469eaccde68d0675f11bb5/image.png)0.8.5https://gitlab.xfce.org/apps/xfce4-dict/-/merge_requests/6Remove "." at the end of Comment string2023-04-21T20:35:39ZscootergrisenRemove "." at the end of Comment string0.8.5https://gitlab.xfce.org/apps/xfce4-dict/-/merge_requests/5Fix build warnings2023-04-21T20:29:05ZGaël BonithonFix build warningsDeprecation warnings excluded (coming from GLibc 2.32), i.e. built with `-Wno-deprecated-declarations`.Deprecation warnings excluded (coming from GLibc 2.32), i.e. built with `-Wno-deprecated-declarations`.0.8.5https://gitlab.xfce.org/apps/xfce4-dict/-/merge_requests/4configure.ac: use AC_PROG_CC_C992021-01-08T20:41:30ZO Hconfigure.ac: use AC_PROG_CC_C99Various parts of Xfce, and libraries used by Xfce, already use C99 features.
Therefore it is reasonable to expect the availibility of a capable compiler.
Current GCC releases silently default to newer C standards, starting with
gcc-5 whi...Various parts of Xfce, and libraries used by Xfce, already use C99 features.
Therefore it is reasonable to expect the availibility of a capable compiler.
Current GCC releases silently default to newer C standards, starting with
gcc-5 which defaults to C11.
Replace AC_PROG_CC with AC_PROG_CC_C99 to switch the discovered, or specified,
compiler to C99.
Signed-off-by: Olaf Hering <olaf@aepfle.de>https://gitlab.xfce.org/apps/xfce4-dict/-/merge_requests/3Remove GSourceFunc casts2023-04-21T20:28:48ZO HRemove GSourceFunc castsConvert the callback into a real GSourceFunc.
Signed-off-by: Olaf Hering <olaf@aepfle.de>Convert the callback into a real GSourceFunc.
Signed-off-by: Olaf Hering <olaf@aepfle.de>0.8.5https://gitlab.xfce.org/apps/xfce4-dict/-/merge_requests/2include stdlib.h to get atoi prototype2023-04-21T20:38:11ZO Hinclude stdlib.h to get atoi prototypeSigned-off-by: Olaf Hering <olaf@aepfle.de>Signed-off-by: Olaf Hering <olaf@aepfle.de>0.8.5https://gitlab.xfce.org/apps/xfce4-dict/-/merge_requests/1Added new icons and use reverse DNS file names2023-04-21T20:28:28ZMaurizio Galli (m4u9)Added new icons and use reverse DNS file names0.8.4