Panel plugin crashes on Wayland

(wrapper-2.0.orig:4072): Gdk-CRITICAL **: 08:46:42.040: gdk_x11_window_get_xid: assertion 'GDK_IS_X11_WINDOW (window)' failed

Core was generated by `/opt/lib/xfce4/panel/wrapper-2.0.orig /opt/lib/xfce4/panel/plugins/libxfce4dict'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x0000000000000003 in ?? ()
[Current thread is 1 (Thread 0x78d549bf9a00 (LWP 4605))]
(gdb) bt
#0  0x0000000000000003 in ??? ()
#1  0x000078d54ca641c3 in XInternAtom (dpy=0x55d4c3c87120, name=name@entry=0x7ffc87c8e3b0 "XFCE_DICT_SEL-1010223312", onlyIfExists=onlyIfExists@entry=0) at /usr/src/debug/libx11/libX11-1.8.10/src/IntAtom.c:175
#2  0x000078d54ded75d9 in dict_plugin_set_selection (dpd=0x55d4c3d58140) at xfce4-dict-plugin.c:152
#3  dict_plugin_construct (plugin=0x55d4c3d636f0 [XfcePanelPlugin]) at xfce4-dict-plugin.c:399
#4  xfce_panel_module_realize (xpp=0x55d4c3d636f0 [XfcePanelPlugin]) at xfce4-dict-plugin.c:432
#5  xfce_panel_module_realize (xpp=0x55d4c3d636f0 [XfcePanelPlugin]) at xfce4-dict-plugin.c:432
#6  0x000078d54d2f582a in g_closure_invoke (closure=0x55d4c3d83630, return_value=0x0, n_param_values=1, param_values=0x7ffc87c8e600, invocation_hint=0x7ffc87c8e550) at ../glib/gobject/gclosure.c:833
#7  0x000078d54d3268df in signal_emit_unlocked_R.isra.0
    (node=node@entry=0x7ffc87c8e6f0, detail=detail@entry=0, instance=instance@entry=0x55d4c3d636f0, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7ffc87c8e600)
    at ../glib/gobject/gsignal.c:3960
#8  0x000078d54d316ca9 in signal_emit_valist_unlocked (instance=instance@entry=0x55d4c3d636f0, signal_id=signal_id@entry=58, detail=detail@entry=0, var_args=var_args@entry=0x7ffc87c8e860)
    at ../glib/gobject/gsignal.c:3519
#9  0x000078d54d316f32 in g_signal_emit_valist (instance=0x55d4c3d636f0, signal_id=58, detail=0, var_args=var_args@entry=0x7ffc87c8e860) at ../glib/gobject/gsignal.c:3262
#10 0x000078d54d316ff4 in g_signal_emit (instance=instance@entry=0x55d4c3d636f0, signal_id=<optimized out>, detail=detail@entry=0) at ../glib/gobject/gsignal.c:3582
#11 0x000078d54d9487fa in gtk_widget_realize (widget=0x55d4c3d636f0 [XfcePanelPlugin]) at ../gtk/gtk/gtkwidget.c:5523
#12 0x000078d54d948bf9 in gtk_widget_map (widget=0x55d4c3d636f0 [XfcePanelPlugin]) at ../gtk/gtk/gtkwidget.c:5049
#13 gtk_widget_map (widget=0x55d4c3d636f0 [XfcePanelPlugin]) at ../gtk/gtk/gtkwidget.c:5034
#14 0x000078d54d2f582a in g_closure_invoke (closure=0x55d4c3ce8cf0, return_value=0x0, n_param_values=1, param_values=0x7ffc87c8ec00, invocation_hint=0x7ffc87c8eb50) at ../glib/gobject/gclosure.c:833
#15 0x000078d54d3266a2 in signal_emit_unlocked_R.isra.0
    (node=node@entry=0x7ffc87c8ecf0, detail=detail@entry=0, instance=instance@entry=0x55d4c3d636f0, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7ffc87c8ec00)
    at ../glib/gobject/gsignal.c:3720
#16 0x000078d54d316ca9 in signal_emit_valist_unlocked (instance=instance@entry=0x55d4c3d636f0, signal_id=signal_id@entry=54, detail=detail@entry=0, var_args=var_args@entry=0x7ffc87c8ee60)
    at ../glib/gobject/gsignal.c:3519
#17 0x000078d54d316f32 in g_signal_emit_valist (instance=0x55d4c3d636f0, signal_id=54, detail=0, var_args=var_args@entry=0x7ffc87c8ee60) at ../glib/gobject/gsignal.c:3262
#18 0x000078d54d316ff4 in g_signal_emit (instance=instance@entry=0x55d4c3d636f0, signal_id=<optimized out>, detail=detail@entry=0) at ../glib/gobject/gsignal.c:3582
#19 0x000078d54d949293 in gtk_widget_show (widget=0x55d4c3d636f0 [XfcePanelPlugin]) at ../gtk/gtk/gtkwidget.c:4852
#20 gtk_widget_show (widget=widget@entry=0x55d4c3d636f0 [XfcePanelPlugin]) at ../gtk/gtk/gtkwidget.c:4825
#21 0x000055d49548511d in main (argc=<optimized out>, argv=<optimized out>) at main.c:360

added 5. Wayland label

added 1. Crash / Freeze label

It turns out, that X11-specific code is actually useless, if I understand it right, it's meant to give focus to the panel plugin's text entry if xfce4-dict --text-field is executed, apparently I broke it 8 years ago when porting dict to gtk3

Since no one complained all this time and to not introduce differences while running under Wayland (is there any protocol to request focus like that?), I think it's fair to drop this argument and the X11 code.

mentioned in commit 1808329e

mentioned in merge request !15 (merged)

mentioned in commit 0bd8a85f

closed with commit 0bd8a85f