xfburn issueshttps://gitlab.xfce.org/apps/xfburn/-/issues2023-03-04T17:24:44Zhttps://gitlab.xfce.org/apps/xfburn/-/issues/56[PATCH] Fix typos and URL in Readme2023-03-04T17:24:44ZThomas Lange[PATCH] Fix typos and URL in ReadmeSee the attached patch.
P.S. I can't create a fork here for a merge request ("You have reached your project limit"). Is this because I only authenticate via GitHub and have no "real" GitLab user for Xfce?
[0001-Update-README.md.patch](...See the attached patch.
P.S. I can't create a fork here for a merge request ("You have reached your project limit"). Is this because I only authenticate via GitHub and have no "real" GitLab user for Xfce?
[0001-Update-README.md.patch](/uploads/a15bbeedc174cd37af8138c782659009/0001-Update-README.md.patch)https://gitlab.xfce.org/apps/xfburn/-/issues/55Segmentation fault on exit if settings file is readonly2023-03-06T01:00:24ZHunter Turcinhuntertur@gmail.comSegmentation fault on exit if settings file is readonly# Reproduction steps
1. `chmod a-r ~/.config/xfburn/settings.xml`
2. Start Xfburn
3. Exit Xfburn
4. Notice a segmentation fault# Reproduction steps
1. `chmod a-r ~/.config/xfburn/settings.xml`
2. Start Xfburn
3. Exit Xfburn
4. Notice a segmentation faultHunter Turcinhuntertur@gmail.comHunter Turcinhuntertur@gmail.comhttps://gitlab.xfce.org/apps/xfburn/-/issues/54Memory corruption and crash when building with xfce4-dev-tools >= 4.17.12023-02-14T12:08:14ZGaël BonithonMemory corruption and crash when building with xfce4-dev-tools >= 4.17.1Git master (d455c4490247e4c0140f25d81f152d08fce97ee6) crashes without warnings, while 0.6.2 shows warnings but does not crash.
Warnings of 0.6.2:
```
(xfburn:48173): GLib-GIO-CRITICAL **: 11:33:40.785: g_simple_action_set_enabled: asser...Git master (d455c4490247e4c0140f25d81f152d08fce97ee6) crashes without warnings, while 0.6.2 shows warnings but does not crash.
Warnings of 0.6.2:
```
(xfburn:48173): GLib-GIO-CRITICAL **: 11:33:40.785: g_simple_action_set_enabled: assertion 'G_IS_SIMPLE_ACTION (simple)' failed
** (xfburn:48173): WARNING **: 11:33:50.701: Hmm, why can we refresh when there is no drive?
** (xfburn:48173): WARNING **: 11:33:51.703: Hmm, why can we refresh when there is no drive?
```
Git master displays the dialog indicating that there is no burner, then crashes if you close the dialog.
Console output:
```
DBG[xfburn-main.c:270] main(): xfburn version 0.6.3git-64f3cf0 for Xfce 4.16
DBG[xfburn-settings.c:275] load_settings(): parsed
** Message: 11:47:03.459: Using UDEV
DBG[xfburn-device-list.c:229] xfburn_device_list_init(): Constructing device list
** Message: 11:47:04.953: Using gstreamer transcoder.
Erreur de segmentation (core dumped)
```
Backtrace:
```
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0x00007f6d06684d7e in g_slice_alloc () from /usr/lib/libglib-2.0.so.0
[Current thread is 1 (Thread 0x7f6d0534b9c0 (LWP 48493))]
(gdb) bt
#0 0x00007f6d06684d7e in g_slice_alloc () at /usr/lib/libglib-2.0.so.0
#1 0x00007f6d0668536e in g_slice_alloc0 () at /usr/lib/libglib-2.0.so.0
#2 0x00007f6d067896bf in g_type_create_instance () at /usr/lib/libgobject-2.0.so.0
#3 0x00007f6d06770550 in () at /usr/lib/libgobject-2.0.so.0
#4 0x00007f6d067724d5 in g_object_new_valist () at /usr/lib/libgobject-2.0.so.0
#5 0x00007f6d06772b4e in g_object_new () at /usr/lib/libgobject-2.0.so.0
#6 0x00007f6d071e5a25 in () at /usr/lib/libgtk-3.so.0
#7 0x00007f6d06789759 in g_type_create_instance () at /usr/lib/libgobject-2.0.so.0
#8 0x00007f6d06770550 in () at /usr/lib/libgobject-2.0.so.0
#9 0x00007f6d06771d80 in g_object_new_with_properties () at /usr/lib/libgobject-2.0.so.0
#10 0x00007f6d06772b7a in g_object_new () at /usr/lib/libgobject-2.0.so.0
#11 0x00007f6d071fbd41 in () at /usr/lib/libgtk-3.so.0
#12 0x00007f6d071f62b8 in () at /usr/lib/libgtk-3.so.0
#13 0x00007f6d071f61cc in () at /usr/lib/libgtk-3.so.0
#14 0x00007f6d073ef94f in () at /usr/lib/libgtk-3.so.0
#15 0x00007f6d071f6c0d in gtk_menu_shell_bind_model () at /usr/lib/libgtk-3.so.0
#16 0x00007f6d071ed09e in gtk_menu_bar_new_from_model () at /usr/lib/libgtk-3.so.0
#17 0x000055e4bb6cece4 in xfburn_main_window_init (mainwin=0x55e4bc808260) at xfburn-main-window.c:199
#18 0x00007f6d06789759 in g_type_create_instance () at /usr/lib/libgobject-2.0.so.0
#19 0x00007f6d06770550 in () at /usr/lib/libgobject-2.0.so.0
#20 0x00007f6d0677295f in g_object_new_valist () at /usr/lib/libgobject-2.0.so.0
#21 0x00007f6d0732d6f2 in gtk_widget_new () at /usr/lib/libgtk-3.so.0
#22 0x000055e4bb6cf7e1 in xfburn_main_window_new () at xfburn-main-window.c:591
#23 0x000055e4bb6bdc00 in main (argc=<optimized out>, argv=<optimized out>) at xfburn-main.c:391
```
It also crashes if you just wait a few seconds, but maybe not always.
Console output:
```
DBG[xfburn-main.c:270] main(): xfburn version 0.6.3git-64f3cf0 for Xfce 4.16
DBG[xfburn-settings.c:275] load_settings(): parsed
** Message: 11:44:59.433: Using UDEV
DBG[xfburn-device-list.c:229] xfburn_device_list_init(): Constructing device list
DBG[xfburn-udev-manager.c:136] cb_device_monitor_uevent(): UDEV: device uevent: change
DBG[xfburn-device-list.c:350] cb_volumes_changed(): Udev volume changed
Erreur de segmentation (core dumped)
```
Backtrace:
```
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0x00007f968bb168be in g_slice_free_chain_with_offset () from /usr/lib/libglib-2.0.so.0
[Current thread is 1 (Thread 0x7f9689fd39c0 (LWP 47569))]
(gdb) bt
#0 0x00007f968bb168be in g_slice_free_chain_with_offset () at /usr/lib/libglib-2.0.so.0
#1 0x0000559d36127a8e in xfburn_device_refresh_info (device=0x559d377080c0, get_speed_info=get_speed_info@entry=1) at xfburn-device.c:508
#2 0x0000559d361280af in refresh (devlist=0x559d3761aee0) at xfburn-device-list.c:368
#3 0x00007f968bbf2210 in g_closure_invoke () at /usr/lib/libgobject-2.0.so.0
#4 0x00007f968bc1fe88 in () at /usr/lib/libgobject-2.0.so.0
#5 0x00007f968bc0ff35 in g_signal_emit_valist () at /usr/lib/libgobject-2.0.so.0
#6 0x00007f968bc101c4 in g_signal_emit () at /usr/lib/libgobject-2.0.so.0
#7 0x00007f968ae334f6 in () at /usr/lib/libffi.so.8
#8 0x00007f968ae2ff5e in () at /usr/lib/libffi.so.8
#9 0x00007f968ae32b73 in ffi_call () at /usr/lib/libffi.so.8
#10 0x00007f968bbf8485 in g_cclosure_marshal_generic () at /usr/lib/libgobject-2.0.so.0
#11 0x00007f968bbf2210 in g_closure_invoke () at /usr/lib/libgobject-2.0.so.0
#12 0x00007f968bc1fe88 in () at /usr/lib/libgobject-2.0.so.0
#13 0x00007f968bc0ff35 in g_signal_emit_valist () at /usr/lib/libgobject-2.0.so.0
#14 0x00007f968bc101c4 in g_signal_emit () at /usr/lib/libgobject-2.0.so.0
#15 0x00007f968bc4443d in () at /usr/lib/libgudev-1.0.so.0
#16 0x00007f968baf681b in g_main_context_dispatch () at /usr/lib/libglib-2.0.so.0
#17 0x00007f968bb4cec9 in () at /usr/lib/libglib-2.0.so.0
#18 0x00007f968baf5d7f in g_main_loop_run () at /usr/lib/libglib-2.0.so.0
#19 0x00007f968c540bb3 in gtk_dialog_run () at /usr/lib/libgtk-3.so.0
#20 0x0000559d36119ea9 in main (argc=<optimized out>, argv=<optimized out>) at xfburn-main.c:299
```Gaël BonithonGaël Bonithonhttps://gitlab.xfce.org/apps/xfburn/-/issues/53Add more recognized image extensions2023-03-06T01:23:36ZHunter Turcinhuntertur@gmail.comAdd more recognized image extensionsCurrently, the "select image" dialog only shows `.iso` by default. Perhaps it should also show `.toast` and `.img`. (Maybe not `.bin` since that implies also having a `.cue` file, which isn't supported.)Currently, the "select image" dialog only shows `.iso` by default. Perhaps it should also show `.toast` and `.img`. (Maybe not `.bin` since that implies also having a `.cue` file, which isn't supported.)Hunter Turcinhuntertur@gmail.comHunter Turcinhuntertur@gmail.comhttps://gitlab.xfce.org/apps/xfburn/-/issues/52Non-fatal assertion error when plugging in a burner2023-02-24T01:56:05ZHunter Turcinhuntertur@gmail.comNon-fatal assertion error when plugging in a burner# Steps
On 0.6.2 or the latest sources:
1. Unplug burner
2. Start Xfburn
3. Acknowledge there isn't a burner
4. Create a data composition
5. Add something
6. Open burn dialog
7. Attach burner
8. Observe the following output (and also t...# Steps
On 0.6.2 or the latest sources:
1. Unplug burner
2. Start Xfburn
3. Acknowledge there isn't a burner
4. Create a data composition
5. Add something
6. Open burn dialog
7. Attach burner
8. Observe the following output (and also the burn dialog not properly updating)
# Output
```
DBG[xfburn-main.c:270] main(): xfburn version 0.6.3git-67388ba for Xfce 4.16
DBG[xfburn-settings.c:275] load_settings(): parsed
** Message: 18:58:35.612: Using UDEV
DBG[xfburn-device-list.c:229] xfburn_device_list_init(): Constructing device list
** Message: 18:58:36.844: Using gstreamer transcoder.
(xfburn:1176840): libxfce4ui-CRITICAL **: 18:58:45.239: xfce_titled_dialog_update_icon: assertion 'icon_name != NULL' failed
DBG[xfburn-udev-manager.c:136] cb_device_monitor_uevent(): UDEV: device uevent: add
DBG[xfburn-device-list.c:350] cb_volumes_changed(): Udev volume changed
** (xfburn:1176840): WARNING **: 18:58:53.605: Hmm, why can we refresh when there is no drive?
** (xfburn:1176840): CRITICAL **: 18:58:53.605: cb_volume_change_end: assertion 'XFBURN_IS_DEVICE (device)' failed
DBG[xfburn-udev-manager.c:136] cb_device_monitor_uevent(): UDEV: device uevent: change
DBG[xfburn-device-list.c:350] cb_volumes_changed(): Udev volume changed
** (xfburn:1176840): WARNING **: 18:58:54.606: Hmm, why can we refresh when there is no drive?
** (xfburn:1176840): CRITICAL **: 18:58:54.606: cb_volume_change_end: assertion 'XFBURN_IS_DEVICE (device)' failed
```Hunter Turcinhuntertur@gmail.comHunter Turcinhuntertur@gmail.comhttps://gitlab.xfce.org/apps/xfburn/-/issues/51Non-fatal assertion failure when loading Xfburn without a burner2022-10-22T00:04:51ZHunter Turcinhuntertur@gmail.comNon-fatal assertion failure when loading Xfburn without a burner# Steps
On both 0.6.2 and the latest sources:
1. Disconnect all burners
2. Launch Xfburn
3. Acknowledge the "no burners" warning
4. Observe a non-fatal assertion failure in the console
# Output
```
DBG[xfburn-main.c:270] main(): xfbu...# Steps
On both 0.6.2 and the latest sources:
1. Disconnect all burners
2. Launch Xfburn
3. Acknowledge the "no burners" warning
4. Observe a non-fatal assertion failure in the console
# Output
```
DBG[xfburn-main.c:270] main(): xfburn version 0.6.3git-67388ba for Xfce 4.16
DBG[xfburn-settings.c:275] load_settings(): parsed
** Message: 17:37:36.781: Using UDEV
DBG[xfburn-device-list.c:229] xfburn_device_list_init(): Constructing device list
** Message: 17:37:38.460: Using gstreamer transcoder.
(xfburn:1165649): GLib-GIO-CRITICAL **: 17:37:38.491: g_simple_action_set_enabled: assertion 'G_IS_SIMPLE_ACTION (simple)' failed
```Hunter Turcinhuntertur@gmail.comHunter Turcinhuntertur@gmail.comhttps://gitlab.xfce.org/apps/xfburn/-/issues/50Adding progress dialog doesn't appear when dragging files to data composition2022-10-21T04:53:58ZHunter Turcinhuntertur@gmail.comAdding progress dialog doesn't appear when dragging files to data composition1. Create a new data composition
2. Drag a large directory from a file manager
3. Observe that there is no adding progress modal
4. Observe that it is possible to crash the program by clicking the folder mid-addition and attempting to re...1. Create a new data composition
2. Drag a large directory from a file manager
3. Observe that there is no adding progress modal
4. Observe that it is possible to crash the program by clicking the folder mid-addition and attempting to remove it
This seems like a case of looking at how the Add button code path brings up the dialog and making sure the drag code path hits it too.Hunter Turcinhuntertur@gmail.comHunter Turcinhuntertur@gmail.comhttps://gitlab.xfce.org/apps/xfburn/-/issues/49Crash when quitting after attempting to cancel a data composition addition2022-10-21T01:57:01ZHunter Turcinhuntertur@gmail.comCrash when quitting after attempting to cancel a data composition addition# Steps
On both 0.6.2 and the latest sources:
1. Create data composition
2. Select a directory with many files, such as a directory for a project that uses NPM
3. Click cancel (not exit) on the addition dialog (note that cancel doesn't...# Steps
On both 0.6.2 and the latest sources:
1. Create data composition
2. Select a directory with many files, such as a directory for a project that uses NPM
3. Click cancel (not exit) on the addition dialog (note that cancel doesn't visually do anything right now)
5. Exit Xfburn
6. See "Segmentation fault" in the terminal
# Traceback
```
[New LWP 1049584]
[New LWP 1049585]
[New LWP 1049587]
[New LWP 1049586]
[New LWP 1049635]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `./xfburn/xfburn'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0x00007ffb966b06e9 in g_type_check_instance_is_fundamentally_a () from /lib/x86_64-linux-gnu/libgobject-2.0.so.0
[Current thread is 1 (Thread 0x7ffb94f8af40 (LWP 1049584))]
Thread 5 (Thread 0x7ffb6ebfd640 (LWP 1049635)):
#0 syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38
#1 0x00007ffb965e170c in g_cond_wait_until () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2 0x00007ffb965623e1 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3 0x00007ffb96562566 in g_async_queue_timeout_pop () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#4 0x00007ffb965c4749 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#5 0x00007ffb965c1a41 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#6 0x00007ffb96294b43 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442
#7 0x00007ffb96326a00 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
Thread 4 (Thread 0x7ffb9336a640 (LWP 1049586)):
#0 0x00007ffb96318d7f in __GI___poll (fds=0x55dc7a55eb70, nfds=1, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
#1 0x00007ffb965e7696 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2 0x00007ffb965903c3 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3 0x00007ffb941a733d in () at /usr/lib/x86_64-linux-gnu/gio/modules/libdconfsettings.so
#4 0x00007ffb965c1a41 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#5 0x00007ffb96294b43 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442
#6 0x00007ffb96326a00 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
Thread 3 (Thread 0x7ffb92b69640 (LWP 1049587)):
#0 0x00007ffb96318d7f in __GI___poll (fds=0x55dc7ae75760, nfds=6, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
#1 0x00007ffb965e7696 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2 0x00007ffb96592293 in g_main_loop_run () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3 0x00007ffb9693cc1a in () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
#4 0x00007ffb965c1a41 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#5 0x00007ffb96294b43 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442
#6 0x00007ffb96326a00 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
Thread 2 (Thread 0x7ffb93b6b640 (LWP 1049585)):
#0 0x00007ffb96318d7f in __GI___poll (fds=0x55dc7a55a3f0, nfds=2, timeout=6474) at ../sysdeps/unix/sysv/linux/poll.c:29
#1 0x00007ffb965e7696 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2 0x00007ffb965903c3 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3 0x00007ffb96590411 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#4 0x00007ffb965c1a41 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#5 0x00007ffb96294b43 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442
#6 0x00007ffb96326a00 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
Thread 1 (Thread 0x7ffb94f8af40 (LWP 1049584)):
#0 0x00007ffb966b06e9 in g_type_check_instance_is_fundamentally_a () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#1 0x00007ffb96699c1f in g_object_unref () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#2 0x00007ffb96da78e9 in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#3 0x00007ffb9668bc6c in g_closure_invoke () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#4 0x00007ffb966a7ae0 in () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#5 0x00007ffb966a9554 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#6 0x00007ffb966a97a3 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#7 0x00007ffb96da7600 in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#8 0x00007ffb96699e71 in g_object_run_dispose () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#9 0x00007ffb96b2c6f0 in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#10 0x00007ffb96b7702a in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#11 0x00007ffb9668bc6c in g_closure_invoke () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#12 0x00007ffb966a7ae0 in () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#13 0x00007ffb966a9554 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#14 0x00007ffb966a97a3 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#15 0x00007ffb96da7600 in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#16 0x00007ffb96699e71 in g_object_run_dispose () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#17 0x00007ffb96db8689 in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#18 0x00007ffb96b7702a in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#19 0x00007ffb9668bd2f in g_closure_invoke () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#20 0x00007ffb966a7ae0 in () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#21 0x00007ffb966a9554 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#22 0x00007ffb966a97a3 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#23 0x00007ffb96da7600 in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#24 0x00007ffb96db70ee in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#25 0x00007ffb96699e71 in g_object_run_dispose () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#26 0x00007ffb9668bd2f in g_closure_invoke () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#27 0x00007ffb966a7b76 in () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#28 0x00007ffb966a9554 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#29 0x00007ffb966a97a3 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#30 0x00007ffb96da7600 in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#31 0x00007ffb96db70ee in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#32 0x00007ffb96699e71 in g_object_run_dispose () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#33 0x00007ffb96c52671 in gtk_main_do_event () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#34 0x00007ffb97338743 in () at /lib/x86_64-linux-gnu/libgdk-3.so.0
#35 0x00007ffb9736ff56 in () at /lib/x86_64-linux-gnu/libgdk-3.so.0
#36 0x00007ffb96592d1b in g_main_context_dispatch () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#37 0x00007ffb965e76f8 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#38 0x00007ffb96592293 in g_main_loop_run () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#39 0x00007ffb96c48cfd in gtk_main () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#40 0x000055dc784b63d6 in main (argc=<optimized out>, argv=<optimized out>) at xfburn-main.c:403
```https://gitlab.xfce.org/apps/xfburn/-/issues/48Non-fatal assertion failure when opening and closing burn dialog2022-10-24T03:36:29ZHunter Turcinhuntertur@gmail.comNon-fatal assertion failure when opening and closing burn dialogOutput from starting the program and then opening and closing the burn dialog:
```
DBG[xfburn-main.c:270] main(): xfburn version 0.6.3git-67388ba for Xfce 4.16
DBG[xfburn-settings.c:275] load_settings(): parsed
** Message: 20:35:10.990...Output from starting the program and then opening and closing the burn dialog:
```
DBG[xfburn-main.c:270] main(): xfburn version 0.6.3git-67388ba for Xfce 4.16
DBG[xfburn-settings.c:275] load_settings(): parsed
** Message: 20:35:10.990: Using UDEV
DBG[xfburn-device-list.c:229] xfburn_device_list_init(): Constructing device list
DBG[xfburn-udev-manager.c:284] xfburn_udev_manager_get_devices(): Found writer 'Dell DVD+/-RW DW316 ' at '/dev/sr0'
DBG[xfburn-device.c:435] xfburn_device_fillin_libburn_info(): libburn will determine BD support based on the disk in the drive
DBG[xfburn-device.c:443] xfburn_device_fillin_libburn_info(): Dell DVD+/-RW DW316 can burn: 1 [cdr: 1, cdrw: 1, dvdr: 1, dvdram: 1]
DBG[xfburn-device.c:355] refresh_disc(): disc_status = 2
DBG[xfburn-device.c:361] refresh_disc(): profile_no = 0x0 (), NOT erasable
** Message: 20:35:11.151: Using gstreamer transcoder.
DBG[xfburn-device-box.c:518] check_disc_validity(): blank_mode = 0
(xfburn:761412): libxfce4ui-CRITICAL **: 20:35:12.340: xfce_titled_dialog_update_icon: assertion 'icon_name != NULL' failed
(xfburn:761412): libxfce4ui-CRITICAL **: 20:35:13.615: xfce_titled_dialog_update_icon: assertion 'icon_name != NULL' failed
```
Reproduced on both the current main branch and on 0.6.2 using Pop!_OS 22.04.Hunter Turcinhuntertur@gmail.comHunter Turcinhuntertur@gmail.comhttps://gitlab.xfce.org/apps/xfburn/-/issues/47Some buffer-related warnings in device-related code during distcheck2022-10-19T02:04:59ZHunter Turcinhuntertur@gmail.comSome buffer-related warnings in device-related code during distcheckLooking at some of the past distcheck jobs, there's some warnings about buffer overruns:
https://gitlab.xfce.org/apps/xfburn/-/jobs/28226
```
In file included from /usr/include/string.h:535,
from /usr/include/glib-2.0/...Looking at some of the past distcheck jobs, there's some warnings about buffer overruns:
https://gitlab.xfce.org/apps/xfburn/-/jobs/28226
```
In file included from /usr/include/string.h:535,
from /usr/include/glib-2.0/glib/galloca.h:33,
from /usr/include/glib-2.0/glib.h:30,
from /usr/include/xfce4/libxfce4util/libxfce4util-config.h:29,
from /usr/include/xfce4/libxfce4util/libxfce4util.h:27,
from ../../../xfburn/xfburn-device.c:24:
In function 'strncpy',
inlined from 'xfburn_device_set_property' at ../../../xfburn/xfburn-device.c:192:7:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:95:10: warning: '__builtin_strncpy' specified bound 80 equals destination size [-Wstringop-truncation]
95 | return __builtin___strncpy_chk (__dest, __src, __len,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
96 | __glibc_objsize (__dest));
| ~~~~~~~~~~~~~~~~~~~~~~~~~
```
```
../../../xfburn/xfburn-device-list.c: In function 'get_libburn_device_list':
../../../xfburn/xfburn-device-list.c:283:8: warning: array subscript 5 is above array bounds of 'char[5]' [-Warray-bounds]
283 | rev[5] = '\0';
| ~~~^~~
../../../xfburn/xfburn-device-list.c:279:10: note: while referencing 'rev'
279 | char rev[5];
| ^~~
```Hunter Turcinhuntertur@gmail.comHunter Turcinhuntertur@gmail.comhttps://gitlab.xfce.org/apps/xfburn/-/issues/46Crash when building from source when attempting to add file to data composition2022-10-19T01:03:32ZHunter Turcinhuntertur@gmail.comCrash when building from source when attempting to add file to data composition# Reproduction steps
After building from source with the default configuration:
1. Open Xfburn
2. Create a new data composition
3. Add a file
4. Select any file
5. Open
# Application output
```
huntertur@kobold:~/workspace/2other/xfb...# Reproduction steps
After building from source with the default configuration:
1. Open Xfburn
2. Create a new data composition
3. Add a file
4. Select any file
5. Open
# Application output
```
huntertur@kobold:~/workspace/2other/xfburn$ ./xfburn/xfburn
DBG[xfburn-main.c:270] main(): xfburn version 0.6.3git-67388ba for Xfce 4.16
DBG[xfburn-settings.c:275] load_settings(): parsed
** Message: 23:43:44.887: Using UDEV
DBG[xfburn-device-list.c:229] xfburn_device_list_init(): Constructing device list
DBG[xfburn-udev-manager.c:284] xfburn_udev_manager_get_devices(): Found writer 'Dell DVD+/-RW DW316 ' at '/dev/sr0'
DBG[xfburn-device.c:435] xfburn_device_fillin_libburn_info(): libburn will determine BD support based on the disk in the drive
DBG[xfburn-device.c:443] xfburn_device_fillin_libburn_info(): Dell DVD+/-RW DW316 can burn: 1 [cdr: 1, cdrw: 1, dvdr: 1, dvdram: 1]
DBG[xfburn-device.c:355] refresh_disc(): disc_status = 2
DBG[xfburn-device.c:361] refresh_disc(): profile_no = 0x0 (), NOT erasable
** Message: 23:43:45.021: Using gstreamer transcoder.
DBG[xfburn-data-composition.c:904] add_cb(): selected files: /home/huntertur/Downloads/temp/test.patch
*** stack smashing detected ***: terminated
Aborted (core dumped)
```
# gdb information
```
[New LWP 502163]
[New LWP 502164]
[New LWP 502165]
[New LWP 502216]
[New LWP 502166]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `./xfburn/xfburn'.
Program terminated with signal SIGABRT, Aborted.
#0 __pthread_kill_implementation (no_tid=0, signo=6, threadid=140269325659968) at ./nptl/pthread_kill.c:44
44 ./nptl/pthread_kill.c: No such file or directory.
[Current thread is 1 (Thread 0x7f92ff542f40 (LWP 502163))]
Thread 5 (Thread 0x7f92fcffd640 (LWP 502166)):
#0 0x00007f9300918d7f in __GI___poll (fds=0x560dad6b1740, nfds=6, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
#1 0x00007f9300be7696 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2 0x00007f9300b92293 in g_main_loop_run () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3 0x00007f9300f3cc1a in () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
#4 0x00007f9300bc1a41 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#5 0x00007f9300894b43 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442
#6 0x00007f9300926a00 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
Thread 4 (Thread 0x7f92cffff640 (LWP 502216)):
#0 syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38
#1 0x00007f9300be170c in g_cond_wait_until () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2 0x00007f9300b623e1 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3 0x00007f9300b62566 in g_async_queue_timeout_pop () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#4 0x00007f9300bc4749 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#5 0x00007f9300bc1a41 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#6 0x00007f9300894b43 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442
#7 0x00007f9300926a00 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
Thread 3 (Thread 0x7f92fd7fe640 (LWP 502165)):
#0 0x00007f9300918d7f in __GI___poll (fds=0x560dacc194c0, nfds=1, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
#1 0x00007f9300be7696 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2 0x00007f9300b903c3 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3 0x00007f92fec6d33d in () at /usr/lib/x86_64-linux-gnu/gio/modules/libdconfsettings.so
#4 0x00007f9300bc1a41 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#5 0x00007f9300894b43 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442
#6 0x00007f9300926a00 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
Thread 2 (Thread 0x7f92fdfff640 (LWP 502164)):
#0 0x00007f9300918d7f in __GI___poll (fds=0x560dacc14e00, nfds=2, timeout=6422) at ../sysdeps/unix/sysv/linux/poll.c:29
#1 0x00007f9300be7696 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2 0x00007f9300b903c3 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3 0x00007f9300b90411 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#4 0x00007f9300bc1a41 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#5 0x00007f9300894b43 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442
#6 0x00007f9300926a00 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
Thread 1 (Thread 0x7f92ff542f40 (LWP 502163)):
#0 __pthread_kill_implementation (no_tid=0, signo=6, threadid=140269325659968) at ./nptl/pthread_kill.c:44
#1 __pthread_kill_internal (signo=6, threadid=140269325659968) at ./nptl/pthread_kill.c:78
#2 __GI___pthread_kill (threadid=140269325659968, signo=signo@entry=6) at ./nptl/pthread_kill.c:89
#3 0x00007f9300842476 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#4 0x00007f93008287f3 in __GI_abort () at ./stdlib/abort.c:79
#5 0x00007f93008896f6 in __libc_message (action=action@entry=do_abort, fmt=fmt@entry=0x7f93009db943 "*** %s ***: terminated\n") at ../sysdeps/posix/libc_fatal.c:155
#6 0x00007f930093676a in __GI___fortify_fail (msg=msg@entry=0x7f93009db92b "stack smashing detected") at ./debug/fortify_fail.c:26
#7 0x00007f9300936736 in __stack_chk_fail () at ./debug/stack_chk_fail.c:24
#8 0x00007f9300ca97c0 in g_signal_emit_by_name () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#9 0x00007f93013a7600 in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#10 0x00007f93013b70ee in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#11 0x00007f9300c99e71 in g_object_run_dispose () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#12 0x0000560dab616b8d in add_cb (widget=<optimized out>, data=<optimized out>) at xfburn-data-composition.c:906
#13 0x00007f9300c8bd2f in g_closure_invoke () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#14 0x00007f9300ca7b76 in () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#15 0x00007f9300ca9554 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#16 0x00007f9300ca99ce in g_signal_emit_by_name () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#17 0x00007f93011ee459 in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#18 0x00007f93013f1710 in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#19 0x00007f9300ca9640 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#20 0x00007f9300ca97a3 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#21 0x00007f93013792a3 in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#22 0x00007f93013f0be5 in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#23 0x00007f9300ca9640 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#24 0x00007f9300ca97a3 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#25 0x00007f9301207d51 in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#26 0x00007f9300c90866 in g_cclosure_marshal_VOID__BOXEDv () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#27 0x00007f9300ca9640 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#28 0x00007f9300ca97a3 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#29 0x00007f93011ffb46 in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#30 0x00007f93012077bf in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#31 0x00007f9301208443 in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#32 0x00007f93011cef90 in gtk_event_controller_handle_event () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#33 0x00007f93013a0045 in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#34 0x00007f93013e5b77 in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#35 0x00007f9300c8bd2f in g_closure_invoke () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#36 0x00007f9300ca7564 in () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#37 0x00007f9300ca8f66 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#38 0x00007f9300ca97a3 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#39 0x00007f93013ae724 in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#40 0x00007f9301251680 in () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#41 0x00007f930125252a in gtk_main_do_event () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#42 0x00007f93018f0743 in () at /lib/x86_64-linux-gnu/libgdk-3.so.0
#43 0x00007f9301927f56 in () at /lib/x86_64-linux-gnu/libgdk-3.so.0
#44 0x00007f9300b92d1b in g_main_context_dispatch () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#45 0x00007f9300be76f8 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#46 0x00007f9300b92293 in g_main_loop_run () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#47 0x00007f9301248cfd in gtk_main () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#48 0x0000560dab5fe445 in main (argc=<optimized out>, argv=<optimized out>) at xfburn-main.c:403
```Hunter Turcinhuntertur@gmail.comHunter Turcinhuntertur@gmail.comhttps://gitlab.xfce.org/apps/xfburn/-/issues/45Update COPYING file2022-03-11T20:53:36ZKevin BowenUpdate COPYING fileThe current license for this component is out of date. Please see
[xfce4-taskmanager Issue #49](https://gitlab.xfce.org/apps/xfce4-taskmanager/-/issues/49)
for additional details & discussion.
Briefly:
```
Comparing the 17 years old...The current license for this component is out of date. Please see
[xfce4-taskmanager Issue #49](https://gitlab.xfce.org/apps/xfce4-taskmanager/-/issues/49)
for additional details & discussion.
Briefly:
```
Comparing the 17 years old file with the new one, we have:
- some whitespace changes
- a new FSF address
- some extra commas
All references to GNU Library General Public License have been replaced with GNU Lesser General Public License
```
cc: @aekorogluKevin BowenKevin Bowenhttps://gitlab.xfce.org/apps/xfburn/-/issues/43Any plans to make new release?2023-03-08T15:00:52ZTomasz KłoczkoAny plans to make new release?At the moment it is more than 210 commits since last release and I think that it would be good to flush currently committed changes (mostly translations) and make new release :)At the moment it is more than 210 commits since last release and I think that it would be good to flush currently committed changes (mostly translations) and make new release :)https://gitlab.xfce.org/apps/xfburn/-/issues/42Update the copyright in the about dialog2023-03-09T16:11:32ZYousuf PhilipsUpdate the copyright in the about dialog![image](/uploads/3f06e7a7b339c1614eca61638ed6f972/image.png)
https://gitlab.xfce.org/apps/xfburn/-/blob/master/xfburn/xfburn-main-window.c#L503![image](/uploads/3f06e7a7b339c1614eca61638ed6f972/image.png)
https://gitlab.xfce.org/apps/xfburn/-/blob/master/xfburn/xfburn-main-window.c#L503https://gitlab.xfce.org/apps/xfburn/-/issues/41Window size problem in 1024x600 resolution2022-10-19T01:10:42ZAlireza AhmadiWindow size problem in 1024x600 resolutionHello.
I'm use Xubuntu in my Asus eee laptop with 1024x600 resolution.
As you can see here it doesn't show correctly.
![Screenshot_2021-03-16_08-10-35](/uploads/68adcb6a04b77d17449b4ae0fd94b39d/Screenshot_2021-03-16_08-10-35.png)Hello.
I'm use Xubuntu in my Asus eee laptop with 1024x600 resolution.
As you can see here it doesn't show correctly.
![Screenshot_2021-03-16_08-10-35](/uploads/68adcb6a04b77d17449b4ae0fd94b39d/Screenshot_2021-03-16_08-10-35.png)https://gitlab.xfce.org/apps/xfburn/-/issues/40Enable Delete key to remove entries2022-10-19T04:01:36ZYousuf PhilipsEnable Delete key to remove entriesThis would improve usability if the user didn't have to go to the toolbar to get to this option, even more importantly as you can't right-click multiple files (issue #34).This would improve usability if the user didn't have to go to the toolbar to get to this option, even more importantly as you can't right-click multiple files (issue #34).https://gitlab.xfce.org/apps/xfburn/-/issues/37Removing entries in audio compilation doesn't always clear their timing from ...2022-10-21T02:27:17ZYousuf PhilipsRemoving entries in audio compilation doesn't always clear their timing from progress barSteps
1. start audio composition
2. add 4 audio files
3. select various tracks and drag them around a few times
4. entries will be duplicated rather than moved (issue #35)
5. delete one entry at a time until there are no more left
6. not...Steps
1. start audio composition
2. add 4 audio files
3. select various tracks and drag them around a few times
4. entries will be duplicated rather than moved (issue #35)
5. delete one entry at a time until there are no more left
6. notice that progress isn't clear
Tested on Xubuntu 20.04 with Xfce 0.6.2.https://gitlab.xfce.org/apps/xfburn/-/issues/35Dragging audio track duplicates it rather than reordering2022-10-20T02:51:45ZYousuf PhilipsDragging audio track duplicates it rather than reorderingSteps:
1. start audio composition
2. add 4 audio files
3. select 1 track and drag it to a new position
4. notice that the track has duplicated and there are now 5 entries
Tested on Xubuntu 20.04 with Xfce 0.6.2.Steps:
1. start audio composition
2. add 4 audio files
3. select 1 track and drag it to a new position
4. notice that the track has duplicated and there are now 5 entries
Tested on Xubuntu 20.04 with Xfce 0.6.2.https://gitlab.xfce.org/apps/xfburn/-/issues/34Right-click on multi-select2022-10-19T03:16:10ZYousuf PhilipsRight-click on multi-selectSteps:
1. open new data composition
2. add multiple files/folders
3. select multiple entries with Ctrl + A or Shift/Ctrl + Click
4. right-click on one of the selected entries
5. only the entry below the mouse will be selected when the co...Steps:
1. open new data composition
2. add multiple files/folders
3. select multiple entries with Ctrl + A or Shift/Ctrl + Click
4. right-click on one of the selected entries
5. only the entry below the mouse will be selected when the context menu opens
If the context menu appears, it should only have the 'Remove' context menu entry, as the 'Create directory' and 'Rename' wouldn't be applicable.
Tested on Xubuntu 20.04 with Xfburn 0.6.2.https://gitlab.xfce.org/apps/xfburn/-/issues/32Cancel button in 'Adding' dialog doesn't work2022-10-21T01:57:01ZYousuf PhilipsCancel button in 'Adding' dialog doesn't workTested on Xubuntu 20.04 with Xfburn 0.6.2, if you start a data composition and insert a folder with many files and directories in it, the 'Adding' dialog will appear, but clicking the Cancel button won't work. The X button in the title b...Tested on Xubuntu 20.04 with Xfburn 0.6.2, if you start a data composition and insert a folder with many files and directories in it, the 'Adding' dialog will appear, but clicking the Cancel button won't work. The X button in the title bar does work.