Unnecessary overshoot effect at window edges

Submitted by Manuel Grießmayr

Assigned to Igor @f2404

Link to original bug (#16648)

Description

Created attachment 9683 Image of ristretto with Numix theme

See screenshot attached. Problem appears only with Numix theme. It doesn't matter if an image has been opened within the image viewer or not. My OS is Xubuntu 20.04 Beta on real hardware ;)

Attachment 9683, "Image of ristretto with Numix theme":

Version: 0.10.0

Theo Linkspfeifer said:

Related Xfce forum thread: https://forum.xfce.org/viewtopic.php?id=13789

Manuel Grießmayr said:

The workaround in the forum thread works for me but unfortunately the solution only works globally and affects all applications for example there is no overflow indication in mousepad anymore. Therefore I would like to request an enhancement to add at least one main css class / id so we can apply the css workaround specific to ristretto.

Andre Miranda @andreldm said:

I saw a similar problem when porting Thunar to gtk3: https://github.com/andreldm/thunar/issues/21 The fix was: https://git.xfce.org/xfce/thunar/commit/?id=375bc40

Theo Linkspfeifer closed a related bug:

*** Bug 16724 has been marked as a duplicate of this bug. ***

Theo Linkspfeifer submitted a patch:

The attached diff simply resets the maximum value of the adjustment so that it does not go lower than the page size.

Patch 9775, "quick diff":
bug16735.diff

Andre Miranda @andreldm said:

The issue is visible with almost any other theme, although Numix makes it much more noticeable. The approach use on Thunar didn't fix the problem, however Theo's patch solves the bug and I didn't notice any regression.

added Patch label

unassigned @f2404

Theo's patch solves the bug and I didn't notice any regression

There is at least one: when the image is zoomed in just enough to show a scroll bar, Ristretto obviously enters an adjustment loop that makes it consume resources unnecessarily.

It is not excluded that this part on adjustment should be reviewed more widely, but it would perhaps be better to do it after !8 (merged) is merged to avoid conflicts.

Theo's patch solves the issue for me. I cannot reproduce this:

when the image is zoomed in just enough to show a scroll bar, Ristretto obviously enters an adjustment loop that makes it consume resources unnecessarily.

Generally I find that Ristretto is slow displaying images compared with lximage-qt, this is not specific to this issue.

closed with commit 072169e7

assigned to @Tamaranch

I did a quick test with commit 072169e7 and it solved the issue with the bars for me. Thanks.

You're welcome, and thanks for testing, it's always useful and appreciated.

changed milestone to %0.12.0