ristretto issueshttps://gitlab.xfce.org/apps/ristretto/-/issues2021-03-30T17:27:32Zhttps://gitlab.xfce.org/apps/ristretto/-/issues/56av1f2021-03-30T17:27:32ZThermiav1fav1f support would be nice. It compresses far better than other algorithms.av1f support would be nice. It compresses far better than other algorithms.https://gitlab.xfce.org/apps/ristretto/-/issues/62Memory leak when porting to GTK 32022-03-12T20:05:12ZGaël BonithonMemory leak when porting to GTK 3A significant amount of the memory used to load an image is not released after it is loaded, whereas it was released before 793ab19e19e7ed8cbeed7f35d1bbe048330977a4.
You can use any image large enough to see this, for example the one in...A significant amount of the memory used to load an image is not released after it is loaded, whereas it was released before 793ab19e19e7ed8cbeed7f35d1bbe048330977a4.
You can use any image large enough to see this, for example the one in #60, or a sample.
Using for example the sample extracted from this image by `convert input.jpg -shave 3000x3000 output.jpg`, Ristretto occupies 1.4 GiB in memory just before the end of the loading. Then, before 793ab19e19e7ed8cbeed7f35d1bbe048330977a4, it would release about 750 MiB, after this commit it doesn't release them anymore.0.12.0Gaël BonithonGaël Bonithonhttps://gitlab.xfce.org/apps/ristretto/-/issues/27Ristretto crashes on VERY LARGE images2022-03-18T10:03:00ZBugzilla MigrationRistretto crashes on VERY LARGE images## Submitted by Igor `@f2404`
Assigned to **Xfce Bug Triage**
**[Link to original bug (#15296)](https://bugzilla.xfce.org/show_bug.cgi?id=15296)**
## Description
The crash is reproducible with this image (JPEG, 30000x22943 pixels,...## Submitted by Igor `@f2404`
Assigned to **Xfce Bug Triage**
**[Link to original bug (#15296)](https://bugzilla.xfce.org/show_bug.cgi?id=15296)**
## Description
The crash is reproducible with this image (JPEG, 30000x22943 pixels, 181MB): https://commons.wikimedia.org/wiki/Template:In_the_Conservatory
Relevant part of the stack trace:
Thread 1 "ristretto" received signal SIGSEGV, Segmentation fault.
0x00007ffff2b784f5 in ?? () from /usr/lib/x86_64-linux-gnu/libpixman-1.so.0
```
#18 0x00007ffff6fcae35 in cairo_paint () at /usr/lib/x86_64-linux-gnu/libcairo.so.2
#19 0x0000000000414b90 in paint_image (ctx=0x65c900, widget=0x8bd4a0) at image_viewer.c:1434
#20 0x0000000000414b90 in rstto_image_viewer_paint (ctx=0x65c900, widget=0x8bd4a0) at image_viewer.c:1623
#21 0x0000000000414b90 in rstto_image_viewer_expose (widget=0x8bd4a0, event=<optimized out>) at image_viewer.c:646
```
If the "Limit rendering quality" setting is enabled, the image can be opened.
However, even with the setting disabled, the app shall not crash.0.12.0Gaël BonithonGaël Bonithonhttps://gitlab.xfce.org/apps/ristretto/-/issues/61Crash on a large image2022-03-18T10:04:25ZGaël BonithonCrash on a large imageUsing the [image provided](https://dolphin-emu.org/m/user/blog/progress-report/2016-november/windwaker35xnative.jpg) in #60, and after cropping it by
```
convert input.jpg -shave 2000x2000 output.jpg
```
opening it in Ristretto gives me...Using the [image provided](https://dolphin-emu.org/m/user/blog/progress-report/2016-november/windwaker35xnative.jpg) in #60, and after cropping it by
```
convert input.jpg -shave 2000x2000 output.jpg
```
opening it in Ristretto gives me the following backtrace (relevant part, cairo compiled from sources with debug symbols):
```
Thread 1 "ristretto" received signal SIGABRT, Aborted.
0x00007ffff6b19d22 in raise () from /usr/lib/libc.so.6
#0 0x00007ffff6b19d22 in raise () at /usr/lib/libc.so.6
#1 0x00007ffff6b03862 in abort () at /usr/lib/libc.so.6
#2 0x00007ffff6b03747 in _nl_load_domain.cold () at /usr/lib/libc.so.6
#3 0x00007ffff6b12616 in () at /usr/lib/libc.so.6
#4 0x00007ffff74cb1cf in _cairo_xlib_shm_pool_create (display=0x555555a67800, size=1083223680, ptr=0x7fffffffce60) at ../src/cairo-xlib-surface-shm.c:622
#5 0x00007ffff74cb2c8 in _cairo_xlib_shm_info_create (display=0x555555a67800, size=1083223680, will_sync=0) at ../src/cairo-xlib-surface-shm.c:650
#6 0x00007ffff74cb8e4 in _cairo_xlib_shm_surface_create (other=0x5555558dd400, format=PIXMAN_x8r8g8b8, width=18964, height=14280, will_sync=0, create_pixmap=4096) at ../src/cairo-xlib-surface-shm.c:836
#7 0x00007ffff74cca26 in _cairo_xlib_surface_create_shm (other=0x5555558dd400, format=PIXMAN_x8r8g8b8, width=18964, height=14280) at ../src/cairo-xlib-surface-shm.c:1162
#8 0x00007ffff74ccab2 in _cairo_xlib_surface_create_similar_shm (other=0x5555558dd400, format=CAIRO_FORMAT_RGB24, width=18964, height=14280) at ../src/cairo-xlib-surface-shm.c:1187
#9 0x00007ffff746f2d5 in INT_cairo_surface_create_similar_image (other=0x5555558dd400, format=CAIRO_FORMAT_RGB24, width=18964, height=14280) at ../src/cairo-surface.c:595
#10 0x00007ffff771d424 in gdk_cairo_set_source_pixbuf () at /usr/lib/libgdk-3.so.0
#11 0x000055555556c7a0 in paint_image (ctx=0x555555a5f000, widget=0x555555605350) at image_viewer.c:1399
#12 rstto_image_viewer_paint (ctx=0x555555a5f000, widget=0x555555605350) at image_viewer.c:1591
#13 rstto_image_viewer_draw (widget=0x555555605350, ctx=0x555555a5f000) at image_viewer.c:608
```
and this output in the terminal:
```
ristretto: ../cairo/src/cairo-xlib-surface-shm.c:619: _cairo_xlib_shm_pool_create: Assertion `*ptr != NULL' failed.
```
The backtrace above is very close to the one in #27 (it's just one intruction above in `image_viewer.c`), but it's not the same, hence the new issue. It is however likely that the two crashes are related.0.12.0Gaël BonithonGaël Bonithonhttps://gitlab.xfce.org/apps/ristretto/-/issues/87JPEG XL support2022-05-10T20:58:07ZArtem S. TashkinovJPEG XL supportWould be really great to get it.
libjxl is now included by most distros.Would be really great to get it.
libjxl is now included by most distros.