1. 13 May, 2022 25 commits
  2. 21 Apr, 2022 1 commit
    • Gaël Bonithon's avatar
      Fix a memory leak in menu item realignment · 209d0b95
      Gaël Bonithon authored
      The absence of the "_swapped" suffix was an oversight (which in this
      case had no directly visible consequence), but the use of
      `gtk_widget_destroy()` was a mistake: it does not dereference an object
      by itself.
      
      Fixes: #164
      209d0b95
  3. 25 Mar, 2022 1 commit
  4. 05 Mar, 2022 2 commits
  5. 01 Mar, 2022 4 commits
    • Gaël Bonithon's avatar
      Cleanup: Avoid code duplication · 6c421b3b
      Gaël Bonithon authored
      6c421b3b
    • Gaël Bonithon's avatar
      Force encoding when reloading · 072820d2
      Gaël Bonithon authored
      By hypothesis the file has already been opened with the current
      encoding, so the question of its validity no longer arises. Moreover, as
      this is a direct call to `mousepad_file_open()`, if the encoding is not
      forced and is only partially valid, the reloading of the file fails
      without even opening the encoding dialog.
      
      Related to !69.
      072820d2
    • Gaël Bonithon's avatar
      Force encoding when it has been explicitly set by the user · 4c902aa8
      Gaël Bonithon authored
      This is a behavior that seems reasonable in general, and in particular
      it fixes at least two cases of unwanted reopening of the encoding
      dialog:
      * when a file is opened directly in the encoding dialog by
        `mousepad -e -- file`, only partially valid encodings are found, and
        one of them is finally used to open the file;
      * similarly when the encoding dialog is opened from the "Open" dialog.
      
      Related to !69
      4c902aa8
    • Gaël Bonithon's avatar
      Do not consider encoding as always user-set in the "Open" dialog · b9093ed7
      Gaël Bonithon authored
      Better match the command line behavior instead: the encoding is
      considered user-set only if it is explicitly changed in the combo box.
      
      Related to !69.
      b9093ed7
  6. 25 Feb, 2022 1 commit
  7. 01 Feb, 2022 1 commit
  8. 17 Nov, 2021 1 commit
  9. 28 Oct, 2021 1 commit
    • Gaël Bonithon's avatar
      Drop restrictions on URI scheme · ff06d7df
      Gaël Bonithon authored
      What was implemented in !112 (and the related commits that followed)
      for the trash can, actually allows to do without any restrictions on the
      URI scheme. This completes the switch to GFile in !64, so that Mousepad
      no longer necessarily relies on the existence of a local path to manage
      a file, but can do so entirely via the GFile abstraction.
      
      This allows in particular to open files via the network in https, or any
      other URI scheme supported by GIO, which is left to impose its own
      restrictions, collected via the error handling already in place.
      
      That said, the existence of the file locally remains the normal and
      preferred mode of use. Nothing is done in particular to overcome the
      slowness that can occur when opening a file via the network, where
      simple existence tests can take a few tenths of a second.
      
      Consequently, without even invoking security issues, the Flatpak version
      should remain delivered without network access by default.
      ff06d7df
  10. 22 Sep, 2021 1 commit
    • Gaël Bonithon's avatar
      Properly disconnect signal handlers · f95152bb
      Gaël Bonithon authored
      These signal handlers will only be called after the destruction of their
      data in rather unlikely cases, but in any case a disconnection was
      missing.
      
      Related to !64.
      f95152bb
  11. 21 Aug, 2021 2 commits