catfish issueshttps://gitlab.xfce.org/apps/catfish/-/issues2023-08-30T17:14:49Zhttps://gitlab.xfce.org/apps/catfish/-/issues/99Drag-to-unmaximise only works in modern CSD window layout, but incorrectly ma...2023-08-30T17:14:49ZSimon DedmanDrag-to-unmaximise only works in modern CSD window layout, but incorrectly maximises in 2nd monitorI was going to ask for an enhancement/bugfix to dragging a maximised Catfish window to cause it to unmaximise and move, like Thunar/everything else, but it turns out this works, but only for modern CSD window layout, not classic titlebar...I was going to ask for an enhancement/bugfix to dragging a maximised Catfish window to cause it to unmaximise and move, like Thunar/everything else, but it turns out this works, but only for modern CSD window layout, not classic titlebar layout. I'm happy enough switching to modern now I know it exists and is more functional, but I figure it's still probably a bug that this doesn't work on classic titlebar layout?
Related: if I unmaximise-drag from a Catfish window maximised in monitor 1 (larger) and drag it to the top of monitor 2 (smaller), causing it to expand to the extents of that monitor, it extends to the correct size while leftmouse is still depressed, but then extends more to be too big, once leftmouse is released. It stays too big until focus is clicked off Catfish, whereupon it shrinks again to correct size (full monitor), and stays that way when focus is switched back onto it. Super weird. It behaves normally if maximised on monitor 2 then dragged to the top of monitor 1. [Video](https://drive.google.com/file/d/1Z-mZBmLwdQf7wxKaGmNOw3wP5MDCndcX/view?usp=sharing).
v4.18.0 on Xubuntu 23.04. Cheers!https://gitlab.xfce.org/apps/catfish/-/issues/98Feature Request: libarchive instead of python zipfile2023-07-30T07:26:04ZSaijin-NaibFeature Request: libarchive instead of python zipfileAfter a bit of poking around, I found that Catfish uses the Python library zipfile for searching within archives, which, depending upon how it is built, can handle DEFLATE, BZ2, and LZMA only. This leaves out a ton of archive formats fol...After a bit of poking around, I found that Catfish uses the Python library zipfile for searching within archives, which, depending upon how it is built, can handle DEFLATE, BZ2, and LZMA only. This leaves out a ton of archive formats folks might be using. For me personally, everything is 7z of some sort.
It looks like post-Python 3.7ish, the libarchive python bindings should support almost every format that libarchive handles.
If Catfish were to use that, we'd be able to search within a ton of different archive formats and would, IMO, lead to a much better user experience.https://gitlab.xfce.org/apps/catfish/-/issues/97The CSD/SSD setting only affects the main window: dialogs should also be affe...2023-07-27T15:28:21ZGaël BonithonThe CSD/SSD setting only affects the main window: dialogs should also be affectedInstead, dialogs (starting with the preferences dialog) are always CSD.Instead, dialogs (starting with the preferences dialog) are always CSD.https://gitlab.xfce.org/apps/catfish/-/issues/94catfish shows files only after it is stopped2023-07-31T06:07:28ZCaneRandagiocatfish shows files only after it is stoppedWhen I run a search, catfish only shows the files it finds **after I stop the search**,
or **after a long time**.
The search is performed on a SATA SSD.
Ubuntu 22.10
Catfish 4.16.4
[catfish.mkv](/uploads/cd0d226256d96ac2b2317f1d3e50434...When I run a search, catfish only shows the files it finds **after I stop the search**,
or **after a long time**.
The search is performed on a SATA SSD.
Ubuntu 22.10
Catfish 4.16.4
[catfish.mkv](/uploads/cd0d226256d96ac2b2317f1d3e504344/catfish.mkv)https://gitlab.xfce.org/apps/catfish/-/issues/90Holding a modifier when Catfish loses focus disables right-click2023-10-11T08:57:48ZnewhoaHolding a modifier when Catfish loses focus disables right-clickIf the Catfish main window loses focus when a modifier (Control or Shift) is being pressed, the value is not removed from `self.keys_pressed` when returning.
This causes the right click menu not to show on results until a modifier is pr...If the Catfish main window loses focus when a modifier (Control or Shift) is being pressed, the value is not removed from `self.keys_pressed` when returning.
This causes the right click menu not to show on results until a modifier is pressed again.
Noticed this after finding/fixing the same bug in !55 (when using a modifier to open the Open dialog). It seems a really unlikely thing to happen under normal circumstances but just thought I'd add it here.https://gitlab.xfce.org/apps/catfish/-/issues/87Drag and Drop to Telegram / Kotatogram doesn't work2023-06-09T11:36:36ZValentin the DeguDrag and Drop to Telegram / Kotatogram doesn't worki'm unable to can drag and drop to telegram :(
the cursor icon turns into "not allowed" and when i release notthing happens
![Снимок_экрана_2022-12-01_23-25-43_xfce_catfish_telegram_drag_drop_fail](/uploads/b3c1501dbd906b4cb95e7600214b...i'm unable to can drag and drop to telegram :(
the cursor icon turns into "not allowed" and when i release notthing happens
![Снимок_экрана_2022-12-01_23-25-43_xfce_catfish_telegram_drag_drop_fail](/uploads/b3c1501dbd906b4cb95e7600214bcbd0/Снимок_экрана_2022-12-01_23-25-43_xfce_catfish_telegram_drag_drop_fail.png)https://gitlab.xfce.org/apps/catfish/-/issues/85catfish crashed with OSError in _execute_child(): [Errno 7] Argument list too...2023-06-09T11:35:36ZSean Daviscatfish crashed with OSError in _execute_child(): [Errno 7] Argument list too long: 'locate'Reported on Launchpad at https://bugs.launchpad.net/ubuntu/+source/catfish/+bug/1968452
DistroRelease: Ubuntu 22.04
Package: catfish 4.16.3-1
```
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/catfish/Catfish...Reported on Launchpad at https://bugs.launchpad.net/ubuntu/+source/catfish/+bug/1968452
DistroRelease: Ubuntu 22.04
Package: catfish 4.16.3-1
```
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/catfish/CatfishWindow.py", line 2079, in perform_query
for filename in self.search_engine.run(keywords, folder, search_zips, regex=True):
File "/usr/lib/python3/dist-packages/catfish/CatfishSearchEngine.py", line 203, in run
for filename in method.run(keywords, path, search_zips, regex,
File "/usr/lib/python3/dist-packages/catfish/CatfishSearchEngine.py", line 752, in run
self.process = subprocess.Popen(command, stdout=subprocess.PIPE,
File "/usr/lib/python3.10/subprocess.py", line 966, in __init__
self._execute_child(args, executable, preexec_fn, close_fds,
File "/usr/lib/python3.10/subprocess.py", line 1842, in _execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
OSError: [Errno 7] Argument list too long: 'locate'
```https://gitlab.xfce.org/apps/catfish/-/issues/82[Enhancement] Catfish - highlight the text-entry search box's magnifying glas...2023-06-09T11:35:11ZNM64[Enhancement] Catfish - highlight the text-entry search box's magnifying glass when the mouse cursor hovers over itI did not realize that the search magnifying glass in catfish is in fact a clickable button - visually it looks identical to the magnifying glass that is in the whisker menu's own text-entry search box, but the magnifying glass in the wh...I did not realize that the search magnifying glass in catfish is in fact a clickable button - visually it looks identical to the magnifying glass that is in the whisker menu's own text-entry search box, but the magnifying glass in the whisker menu's own text-entry search box is *not* a clickable button.
So yeah, providing some sort of visual feedback that it's actually a clickable button would be useful, and presumably the same goes for the (X) stop button when a search is actually in progress.
Before discovering that it was a clickable button, I thought one *had* to press the enter key instead to make a search.https://gitlab.xfce.org/apps/catfish/-/issues/81Improve documentation on how to use search2023-06-09T11:34:16ZdandyImprove documentation on how to use searchWould like to see better documentation about how using the search textbox, for example how to search in file full path "media" and "db.img", for example
`/mnt/windows/Users/user/Pictures/media/games/mydb.img`
With bash would be:
````
fi...Would like to see better documentation about how using the search textbox, for example how to search in file full path "media" and "db.img", for example
`/mnt/windows/Users/user/Pictures/media/games/mydb.img`
With bash would be:
````
find / |grep -i 'media' |grep -i 'db.img'
````https://gitlab.xfce.org/apps/catfish/-/issues/80understand $LOCATE_PATH=~/.locatedb and do... something better2023-06-07T18:12:24ZSean Davisunderstand $LOCATE_PATH=~/.locatedb and do... something betterReported downstream on Debian. [#1000429](https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1000429)
catfish has a hard-coded path to mlocate's default database path:
https://codesearch.debian.net/search?q=pkg%3Acatfish+mlocate&lit...Reported downstream on Debian. [#1000429](https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1000429)
catfish has a hard-coded path to mlocate's default database path:
https://codesearch.debian.net/search?q=pkg%3Acatfish+mlocate&literal=1
https://sources.debian.org/src/catfish/4.16.3-1/catfish_lib/catfishconfig.py/#L32
mlocate and plocate support $LOCATE_PATH being a colon-separated list of paths to locate databases:
https://manpages.debian.org/bullseye-backports/plocate/plocate.1.en.html#ENVIRONMENT
I use this to run updatedb directly on the NAS, which is MUCH more efficient.
The commands are approximately this:
# on the file server, generate ~twb/.locatedb
sudo -H -u twb nice nocache updatedb --require-visibility=no --output .locatedb --database-root ~twb
# on the desktop, where ~twb is NFS and / is Debian Live
export LOCATE_PATH=~twb/.locatedb
locate foo
catfish
I think with Debian 11's catfish, it will ALWAYS pop up this alert:
The search database is more than 7 days old. Update now? [Update] [X]
I'm not sure EXACTLY what the correct semantics here should be, but
the current behaviour is definitely annoying me! :-)https://gitlab.xfce.org/apps/catfish/-/issues/76Show all file types2023-06-09T11:33:48ZMichael HarveyShow all file typesJetBrains (CLion in this case) uses Thunar's "search" function to open the directory containing log files, which brings up Catfish. Catfish displays an empty window with "No files found." There is no button to show all files. If I select...JetBrains (CLion in this case) uses Thunar's "search" function to open the directory containing log files, which brings up Catfish. Catfish displays an empty window with "No files found." There is no button to show all files. If I select "Other" and enter "*" or ".*" it still doesn't show anything. If I enter "*" in the search bar it shows nothing.
In fact the directory that CLion opens contains a idea.log file as idea.log.1, idea.log.2, etc; but there is no way to see that these files exist, or that any files exist at all, or get any clue what their names might be so I can search for them. Since Catfish doesn't show the path to the current directory, I can't even open a terminal to look at it manually.
I did finally get it to show .log files, by entering "log" in the search bar. There was no clue that this was what I needed to do, or that what the filename might be. Catfish says "try making your search less specific" but I never searched for anything! This was a very frustrating experience.
When I enter "idea" in the search bar I see all log files, and if I then click "documents" it filters and shows only "idea.log". So far so good; but if I open Catfish and just click "Documents" it does nothing. Again I have to enter a search parameter (and NOT the obvious '*') to get anything to show up. This feels backwards and not what I expect. The button is there, if I click it I expect to see all document types.
Suggestions:
- Offer a way to display "all files"
- Display "all files" as the default when opening a directory on the command line, and filter down the list using the search bar. That is way more friendly than showing nothing and leaving the user to guess.
- Make the file types buttons default to showing all files of a given type, if no search filter is provided
- There should be a way to identify the current folder, for cases where Catfish is opened by another program and you don't know what you're looking athttps://gitlab.xfce.org/apps/catfish/-/issues/75Broken symlinks not found/shown in results2022-02-18T22:44:19ZnewhoaBroken symlinks not found/shown in resultsCatfish filename search doesn't return results for broken symlinks.
Showing `find` and `mate-search-tool` (which I think might use `find`) for comparison:
Edit: `link to symbolic` in this picture is a relative link and should be `lin...Catfish filename search doesn't return results for broken symlinks.
Showing `find` and `mate-search-tool` (which I think might use `find`) for comparison:
Edit: `link to symbolic` in this picture is a relative link and should be `link to relative`. Messed up on the wording.
![catfish-broken-symlinks](/uploads/525a6f346dad579ad606b7db8ef09d1c/catfish-broken-symlinks.png)https://gitlab.xfce.org/apps/catfish/-/issues/74Support thumbnail sizes x-large and xx-large2023-06-09T11:33:05ZnewhoaSupport thumbnail sizes x-large and xx-largeThunar and Tumbler have [added support for larger thumbnail previews](https://gitlab.xfce.org/xfce/thunar/-/issues/606). With higher resolutions becoming more common it would be nice to have larger thumbnails.
[Thunar implementation](ht...Thunar and Tumbler have [added support for larger thumbnail previews](https://gitlab.xfce.org/xfce/thunar/-/issues/606). With higher resolutions becoming more common it would be nice to have larger thumbnails.
[Thunar implementation](https://gitlab.xfce.org/xfce/thunar/-/commit/9657a28263b1a593fe36b54a7baf3c5094f83ad9)
[Tumbler implementation](https://gitlab.xfce.org/xfce/tumbler/-/commit/5affdb5ccdba711ada11f4cde7d7acc840b5a4be)https://gitlab.xfce.org/apps/catfish/-/issues/73Symlinks to parent folders not showing in filename results2021-12-20T02:12:40ZnewhoaSymlinks to parent folders not showing in filename results1) Make a folder `Test`
2) Make a link to `Test` (`link to test`)
3) Put `link to test` in the folder `Test`
Open catfish and do a filename search for `test` in the `Test` folder, or any parent of the `Test` folder. `link to test` will ...1) Make a folder `Test`
2) Make a link to `Test` (`link to test`)
3) Put `link to test` in the folder `Test`
Open catfish and do a filename search for `test` in the `Test` folder, or any parent of the `Test` folder. `link to test` will not show in the results.
Found this when trying to replicate #72 outside of /proc. I'm guessing looping symlinks are probably blocked from being searched but the symlink file themselves should probably show up.
Tried it with `find` and `mate-search-tool` and got expected results.
![cf-links-not-found](/uploads/e40eb3e065aaa0e5dd125ecf30b7c6f6/cf-links-not-found.png)https://gitlab.xfce.org/apps/catfish/-/issues/72Duplicate results with symlink folders in /proc/2021-12-20T02:12:40ZnewhoaDuplicate results with symlink folders in /proc/When doing a filename search on `/`, I noticed I was getting a lot of duplicate results from `/proc/`
A new folder is created in `/proc/` for every process. The folder is numbered by the PID. Inside of those numbered folders is a `cwd` ...When doing a filename search on `/`, I noticed I was getting a lot of duplicate results from `/proc/`
A new folder is created in `/proc/` for every process. The folder is numbered by the PID. Inside of those numbered folders is a `cwd` symlink folder that links to the current working directory of the process (which will usually be the user's home folder). There may also be a folder called `task` which may contain another `cwd` symlink. The `cwd` symlinks is what was producing all the duplicate results.
---
I haven't done much with the Catfish filename search or walking parts, so I'm not that familiar with how it checks for duplicates or deals with symlinked folders.
Maybe Catfish could keep a list of symlinked folders and not search those until last?
I thought about maybe adding `/proc/` to the exclude list for a simple fix but some of the files in there contain useful info that could be searched with fulltext search (CPU/hardware info). Plus that issue might pop up again with other symlinked folders.
Anyway, I don't mind helping out with this if needed, just need some direction/ideas.https://gitlab.xfce.org/apps/catfish/-/issues/71Catfish 4.16.3 GUI feature content search checkbok directly next to folder field2023-06-09T11:31:55ZartofitCatfish 4.16.3 GUI feature content search checkbok directly next to folder fieldHi,
many thanks for Catfish.
I noticed that in my Catfish searches, I often toggle between file content search and file name search.
If this exist under the preferences menu, it would be easier and quicker to have it next to the folder...Hi,
many thanks for Catfish.
I noticed that in my Catfish searches, I often toggle between file content search and file name search.
If this exist under the preferences menu, it would be easier and quicker to have it next to the folder entry field.
See attached mocked GUI.
![Catfish_4.16.3_Modern_search_G2](/uploads/997e50d91313db047d3b6e805fe3b9bc/Catfish_4.16.3_Modern_search_G2.jpg)
Thankshttps://gitlab.xfce.org/apps/catfish/-/issues/70Catfish 4.16.3: allow GUI to run as catfish --iso-time2023-06-09T11:30:31ZartofitCatfish 4.16.3: allow GUI to run as catfish --iso-timeHi,
thanks for Catfish.
The Gui of catfish does not display the search results in iso-time format, under preferences menu it is not possible to set search result in iso format.
However, it is possible to have this feature simply by run...Hi,
thanks for Catfish.
The Gui of catfish does not display the search results in iso-time format, under preferences menu it is not possible to set search result in iso format.
However, it is possible to have this feature simply by running in terminal:
`catfish --iso-time`
Desired feature:
add in preferences menu a checkbox entry which would be name as for instance "iso date format display".
It is missing GUI preferences feature of already coded feature.
In case you would need help for GUI translation, just ask.https://gitlab.xfce.org/apps/catfish/-/issues/68Allow to uncheck "Search file contents" from command line2023-06-09T11:22:59ZAlbert KalchmairAllow to uncheck "Search file contents" from command lineI would like to create two shortcuts for catfish: one for searching files by file name and one for searching by file contents.
There is no way to keep catfish from restoring an activated "Search file contents" from a previous session. M...I would like to create two shortcuts for catfish: one for searching files by file name and one for searching by file contents.
There is no way to keep catfish from restoring an activated "Search file contents" from a previous session. Maybe a --no-fulltext option could be added?https://gitlab.xfce.org/apps/catfish/-/issues/57Zipfile search issues2022-07-16T21:19:37ZnewhoaZipfile search issuesThese are some remaining issues from the zipfile search patch. Trying to collect the issues here and hope to take care of them.
---
**Sidebar Filters**
* [ ] File Type Filter doesn't filter zip contents (documents in zip files won't s...These are some remaining issues from the zipfile search patch. Trying to collect the issues here and hope to take care of them.
---
**Sidebar Filters**
* [ ] File Type Filter doesn't filter zip contents (documents in zip files won't show if Documents selected)
* [ ] Modified Filter only filters zip file, not contents
* [ ] Other Filter - Doesn't allow you to expand zip contents if .zip is searched (not sure if it should change)
* [ ] Other Filter - Doesn't filter zip contents by ext (if .txt searched it won't show .txt files in zip files)
---
**Fulltext Search**
- [ ] Doesn't filter files through `def is_txt` (to filter non-text files)
- [ ] Doesn't filter files through `def check_charset` (which checks for non-utf-8 files and skips binary files)
- [ ] Doesn't search zip documents within zip files (Example, .odt file in .zip file will not be searched).
---
**Filename Search**
- [ ] Match Results Exactly hides zip files (workaround, select 'Match Exactly' then search)
- [ ] Doesn't search zip files within zip files for filenames.
---
**Miscellaneous**
- [x] Right Click -> Open on folder in .zip file gives an error (!39)
- [x] Freeze with special files (like pipe files). Zipfile doesn't check if os.path.isfile, needs to be done before checking if zip. (!36)
- [ ] Copy Location probably shouldn't show on zipped files since they don't have a location. Currently the path of the archive itself is copied, which could be confusing.
---https://gitlab.xfce.org/apps/catfish/-/issues/56Report time taken to complete search.2023-06-09T11:17:24Zalt coinReport time taken to complete search.A nice feature would be to report the time when a search completes or is cancelled.
Currently, catfish only show "X files found" in the status on the bottom. It would be great to show "X files found in Y seconds".
Currently, I am tryin...A nice feature would be to report the time when a search completes or is cancelled.
Currently, catfish only show "X files found" in the status on the bottom. It would be great to show "X files found in Y seconds".
Currently, I am trying to compare performance search methods for debugging reasons, and I have to start a timer independently and be ready to stop it when the search end, which is not exactly professional. :smile: