Commit ff5885ca authored by Carlos Soriano's avatar Carlos Soriano Committed by Carlos Soriano
Browse files

Allow uncached comment authors

We do not cache Bugzilla users that match the default assignee or the
default QA contact for a component or a product, because the GNOME
Bugzilla instance typically uses fake addresses for those fields. Sadly,
some products over the years decided to use real people as default
assignees and QA contacts, and those people may not have used an email
address that is mapped on any of the GNOME infrastructure services.

This means that as soon as we get a comment from a person who's the
default assignee for a specific bug, we get an empty entry in the users
cache, and it breaks the migration script.
parent 3f81db5f
......@@ -252,7 +252,12 @@ def processbug(bgo, target, user_cache, milestone_cache, bzbug):
emoji, action, body = analyze_bugzilla_comment(comment,
attachment_metadata)
author = user_cache[comment['author']].display_name()
if user_cache[comment['author']] is not None:
author = user_cache[comment['author']].display_name()
else:
author = comment['author']
gitlab_comment = template.render_comment(emoji, author, action, body,
comment_attachment)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment